fix(kmir): preserve symbolic parallel proving server selection#980
Draft
fix(kmir): preserve symbolic parallel proving server selection#980
Conversation
Use the Haskell-only symbolic path without advertising a mismatched LLVM library, and fall back to KoreServer for parallel proof exploration when no proof-specific LLVM library exists. This removes the PR853 empty-response crash on symbolic proofs without reintroducing symbolic llvm-kompile.
Contributor
Author
|
Added TDD-structured follow-up commits for HS-only booster wiring:\n\n- test(kmir): add hs-only symbol env wiring unit tests\n- feat(kmir): pass KMIR_HS_ONLY_SYMBOLS to kore-rpc-booster\n\nRed/green evidence:\n- Red: -> 3 AttributeError failures before wiring\n- Green: same command -> 3 passed after wiring |
Contributor
Author
|
Correction with exact refs:\n\nAdded TDD-structured follow-up commits for HS-only booster wiring:\n- 0f208ed: test(kmir): add hs-only symbol env wiring unit tests\n- 6ef9fc9: feat(kmir): pass KMIR_HS_ONLY_SYMBOLS to kore-rpc-booster\n\nRed/green evidence command:\nuv --project kmir run -- pytest kmir/src/tests/unit/test_kmir_hs_only_symbols.py -q\n- red (before wiring): 3 AttributeError failures\n- green (after wiring): 3 passed |
Stevengre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KMIR_HS_ONLY_SYMBOLS:KMIR.hs_only_symbols_from_env()KMIR.kore_rpc_booster_command_from_env()kore-rpc-boostercommand when HS-only symbols are configured; otherwise keep the existing default RPC path.kompile_smir, when HS-only symbols are configured:llvm-kompilemir-semantics.llvm-library)KoreServerinstead ofBoosterServer.Testing
Local automated checks:
PYTHONPATH=kmir/src make check(pass)uv run pytest -q src/tests/unit(pass)test_exec_smir[closure-call-llvm]test_prove_rs[iter-eq-copied-take-dereftruncate]6 passed in 114.45sRemote regression (zhaoji, accepted path):
unset KMIR_HS_ONLY_SYMBOLS && ./run-proofs.sh -t 1800 test_process_get_account_data_sizeProofStatus.PASSED,prove_exit_code=0,duration_seconds=145,nodes=15,pending=0,failing=0,stuck=0kore-rpc-booster + --llvm-backend-librarystill passes on the existing path without forcing HS-only mode.GitHub checks:
22986255885was rerun (attempt 2) after cancelling a stale long-running attempt.Integration Testsis still pending.